Resolve PHPMD warnings

This commit is contained in:
QWp6t
2015-12-27 23:59:32 -08:00
committed by Ben Word
parent 6a4d3bd51a
commit c5f3724efd
2 changed files with 13 additions and 3 deletions

View File

@@ -5,11 +5,22 @@ use Roots\Sage\Assets\JsonManifest;
use Roots\Sage\Template\WrapperCollection;
use Roots\Sage\Template\WrapperInterface;
/**
* @param WrapperInterface $wrapper
* @param string $slug
* @return string
* @throws \Exception
* @SuppressWarnings(PHPMD.StaticAccess) This is a helper function, so we can suppress this warning
*/
function template_wrap(WrapperInterface $wrapper, $slug = 'base') {
WrapperCollection::add($wrapper, $slug);
return $wrapper->getWrapper();
}
/**
* @param string $slug
* @return string
*/
function template_unwrap($slug = 'base') {
return WrapperCollection::get($slug)->getTemplate();
}

View File

@@ -30,14 +30,13 @@ class WrapperCollection
/**
* @param WrapperInterface $wrapper
* @param string $slug
* @param bool $overwriteIfExists
* @return $this
* @throws \Exception
*/
public static function add(WrapperInterface $wrapper, $slug = '', $overwriteIfExists = false)
public static function add(WrapperInterface $wrapper, $slug = '')
{
$slug = $slug ?: $wrapper->getSlug();
if (self::instance()->exists($slug) && !$overwriteIfExists) {
if (self::instance()->exists($slug)) {
throw new \Exception("Wrapper $slug already exists.");
}
self::instance()->wrappers[$slug] = $wrapper;