Merge pull request #1191 from alexsomeoddpilot/unused-parameters

Unused parameters and declared properties

lib/activation.php

@@ -15,7 +15,7 @@ function roots_theme_activation_options_init() {
 }
 add_action('admin_init', 'roots_theme_activation_options_init');
 
-function roots_activation_options_page_capability($capability) {
+function roots_activation_options_page_capability() {
   return 'edit_theme_options';
 }
 add_filter('option_page_capability_roots_activation_options', 'roots_activation_options_page_capability');
@@ -24,7 +24,7 @@ function roots_theme_activation_options_add_page() {
   $roots_activation_options = roots_get_theme_activation_options();
 
   if (!$roots_activation_options) {
-    $theme_page = add_theme_page(
+    add_theme_page(
       __('Theme Activation', 'roots'),
       __('Theme Activation', 'roots'),
       'edit_theme_options',
@@ -141,7 +141,7 @@ function roots_theme_activation_action() {
         'post_type' => 'page'
       );
 
-      $result = wp_insert_post($add_default_pages);
+      wp_insert_post($add_default_pages);
     }
 
     $home = get_page_by_title(__('Home', 'roots'));

lib/extras.php

@@ -2,7 +2,7 @@
 /**
  * Clean up the_excerpt()
  */
-function roots_excerpt_more($more) {
+function roots_excerpt_more() {
   return ' &hellip; <a href="' . get_permalink() . '">' . __('Continued', 'roots') . '</a>';
 }
 add_filter('excerpt_more', 'roots_excerpt_more');

lib/gallery.php

@@ -123,7 +123,6 @@ if (current_theme_supports('bootstrap-gallery')) {
  * Add class="thumbnail img-thumbnail" to attachment items
  */
 function roots_attachment_link_class($html) {
-  $postid = get_the_ID();
   $html = str_replace('<a', '<a class="thumbnail img-thumbnail"', $html);
   return $html;
 }

lib/nav.php

@@ -74,6 +74,8 @@ add_filter('nav_menu_item_id', '__return_null');
  * Use Roots_Nav_Walker() by default
  */
 function roots_nav_menu_args($args = '') {
+  $roots_nav_menu_args = array();
+
   $roots_nav_menu_args['container'] = false;
 
   if (!$args['items_wrap']) {

lib/utils.php

@@ -8,7 +8,7 @@ function is_element_empty($element) {
 }
 
 // Tell WordPress to use searchform.php from the templates/ directory
-function roots_get_search_form($form) {
+function roots_get_search_form() {
   $form = '';
   locate_template('/templates/searchform.php', true, false);
   return $form;

lib/wrapper.php

@@ -15,7 +15,13 @@ function roots_sidebar_path() {
 
 class Roots_Wrapping {
   // Stores the full path to the main template file
-  static $main_template;
+  public static $main_template;
+
+  // basename of template file
+  public $slug;
+
+  // array of templates
+  public $templates;
 
   // Stores the base name of the template file; e.g. 'page' for 'page.php' etc.
   static $base;