Resolve PHPMD warnings
This commit is contained in:
@@ -5,11 +5,22 @@ use Roots\Sage\Assets\JsonManifest;
|
|||||||
use Roots\Sage\Template\WrapperCollection;
|
use Roots\Sage\Template\WrapperCollection;
|
||||||
use Roots\Sage\Template\WrapperInterface;
|
use Roots\Sage\Template\WrapperInterface;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @param WrapperInterface $wrapper
|
||||||
|
* @param string $slug
|
||||||
|
* @return string
|
||||||
|
* @throws \Exception
|
||||||
|
* @SuppressWarnings(PHPMD.StaticAccess) This is a helper function, so we can suppress this warning
|
||||||
|
*/
|
||||||
function template_wrap(WrapperInterface $wrapper, $slug = 'base') {
|
function template_wrap(WrapperInterface $wrapper, $slug = 'base') {
|
||||||
WrapperCollection::add($wrapper, $slug);
|
WrapperCollection::add($wrapper, $slug);
|
||||||
return $wrapper->getWrapper();
|
return $wrapper->getWrapper();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @param string $slug
|
||||||
|
* @return string
|
||||||
|
*/
|
||||||
function template_unwrap($slug = 'base') {
|
function template_unwrap($slug = 'base') {
|
||||||
return WrapperCollection::get($slug)->getTemplate();
|
return WrapperCollection::get($slug)->getTemplate();
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -30,14 +30,13 @@ class WrapperCollection
|
|||||||
/**
|
/**
|
||||||
* @param WrapperInterface $wrapper
|
* @param WrapperInterface $wrapper
|
||||||
* @param string $slug
|
* @param string $slug
|
||||||
* @param bool $overwriteIfExists
|
|
||||||
* @return $this
|
* @return $this
|
||||||
* @throws \Exception
|
* @throws \Exception
|
||||||
*/
|
*/
|
||||||
public static function add(WrapperInterface $wrapper, $slug = '', $overwriteIfExists = false)
|
public static function add(WrapperInterface $wrapper, $slug = '')
|
||||||
{
|
{
|
||||||
$slug = $slug ?: $wrapper->getSlug();
|
$slug = $slug ?: $wrapper->getSlug();
|
||||||
if (self::instance()->exists($slug) && !$overwriteIfExists) {
|
if (self::instance()->exists($slug)) {
|
||||||
throw new \Exception("Wrapper $slug already exists.");
|
throw new \Exception("Wrapper $slug already exists.");
|
||||||
}
|
}
|
||||||
self::instance()->wrappers[$slug] = $wrapper;
|
self::instance()->wrappers[$slug] = $wrapper;
|
||||||
|
|||||||
Reference in New Issue
Block a user