From ede699368e65c59c60d106c20e20565e2c0fe1c6 Mon Sep 17 00:00:00 2001 From: Kim Helge Frimanslund <1223194+kimhf@users.noreply.github.com> Date: Sat, 27 Oct 2018 11:53:52 +0200 Subject: [PATCH 1/3] Bring hook run sequence in line with expected WordPress behaviour --- app/filters.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/app/filters.php b/app/filters.php index fde2e2c..efdf388 100644 --- a/app/filters.php +++ b/app/filters.php @@ -47,6 +47,15 @@ collect([ * Render page using Blade */ add_filter('template_include', function ($template) { + collect(['get_header', 'wp_head'])->each(function ($tag) { + ob_start(); + do_action($tag); + $c = ob_get_clean(); + remove_all_actions($tag); + add_action($tag, function () use ($c) { + echo $c; + }); + }); $data = collect(get_body_class())->reduce(function ($data, $class) use ($template) { return apply_filters("sage/template/{$class}/data", $data, $template); }, []); From 79fddf944ff28c6cbf090416334098682a765b3d Mon Sep 17 00:00:00 2001 From: Kim Helge Frimanslund <1223194+kimhf@users.noreply.github.com> Date: Sat, 27 Oct 2018 11:54:30 +0200 Subject: [PATCH 2/3] Remove no longer needed script enqueue fix --- app/helpers.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/helpers.php b/app/helpers.php index f2ab4a9..2a6c284 100644 --- a/app/helpers.php +++ b/app/helpers.php @@ -52,10 +52,6 @@ function config($key = null, $default = null) */ function template($file, $data = []) { - if (!is_admin() && remove_action('wp_head', 'wp_enqueue_scripts', 1)) { - wp_enqueue_scripts(); - } - return sage('blade')->render($file, $data); } From 435e9f26dc8617100b94b5b45ec9239def5ac00e Mon Sep 17 00:00:00 2001 From: Kim Helge Frimanslund <1223194+kimhf@users.noreply.github.com> Date: Sun, 28 Oct 2018 23:37:54 +0100 Subject: [PATCH 3/3] More descriptive variable name --- app/filters.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/filters.php b/app/filters.php index efdf388..9eccb85 100644 --- a/app/filters.php +++ b/app/filters.php @@ -50,10 +50,10 @@ add_filter('template_include', function ($template) { collect(['get_header', 'wp_head'])->each(function ($tag) { ob_start(); do_action($tag); - $c = ob_get_clean(); + $output = ob_get_clean(); remove_all_actions($tag); - add_action($tag, function () use ($c) { - echo $c; + add_action($tag, function () use ($output) { + echo $output; }); }); $data = collect(get_body_class())->reduce(function ($data, $class) use ($template) {