From 2f51b51c95c4aaefb1188432791bb9ffae30e703 Mon Sep 17 00:00:00 2001 From: Nathan Knowler Date: Sat, 9 Jun 2018 09:49:08 -0600 Subject: [PATCH 1/3] Enable source comments in Sass --- resources/assets/build/webpack.config.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/resources/assets/build/webpack.config.js b/resources/assets/build/webpack.config.js index 5d1c538..25a4c09 100644 --- a/resources/assets/build/webpack.config.js +++ b/resources/assets/build/webpack.config.js @@ -89,7 +89,12 @@ let webpackConfig = { }, }, { loader: 'resolve-url', options: { sourceMap: config.enabled.sourceMaps } }, - { loader: 'sass', options: { sourceMap: config.enabled.sourceMaps } }, + { + loader: 'sass', options: { + sourceMap: config.enabled.sourceMaps, + sourceComments: true + } + }, ], }), }, From 405aedfb13ce7f2f5a5c0a48bee8b8636c99111b Mon Sep 17 00:00:00 2001 From: Nathan Knowler Date: Sat, 9 Jun 2018 09:49:34 -0600 Subject: [PATCH 2/3] Run autoprefixer before minification --- resources/assets/build/postcss.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/assets/build/postcss.config.js b/resources/assets/build/postcss.config.js index 6e6dd87..ef02554 100644 --- a/resources/assets/build/postcss.config.js +++ b/resources/assets/build/postcss.config.js @@ -8,8 +8,8 @@ module.exports = ({ file, options }) => { return { parser: options.enabled.optimize ? 'postcss-safe-parser' : undefined, plugins: { - cssnano: options.enabled.optimize ? cssnanoConfig : false, autoprefixer: true, + cssnano: options.enabled.optimize ? cssnanoConfig : false, }, }; }; From 4a9094b12d98e1e1c9e1c35b13042419f3c955d8 Mon Sep 17 00:00:00 2001 From: Nathan Knowler Date: Sat, 9 Jun 2018 10:34:55 -0600 Subject: [PATCH 3/3] Add missing trailing commas in 2f51b51 Forgot to lint. --- resources/assets/build/webpack.config.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/assets/build/webpack.config.js b/resources/assets/build/webpack.config.js index 25a4c09..888a1a6 100644 --- a/resources/assets/build/webpack.config.js +++ b/resources/assets/build/webpack.config.js @@ -92,8 +92,8 @@ let webpackConfig = { { loader: 'sass', options: { sourceMap: config.enabled.sourceMaps, - sourceComments: true - } + sourceComments: true, + }, }, ], }),