Merge pull request #1487 from austinpray/gulpDebug

Allow `debugger` statements in development JS
This commit is contained in:
Austin Pray
2015-06-20 22:39:10 -05:00
2 changed files with 12 additions and 3 deletions

View File

@@ -1,5 +1,6 @@
### HEAD ### HEAD
* Add search templates ([#1459](https://github.com/roots/sage/issues/1459)) * Add search templates ([#1459](https://github.com/roots/sage/issues/1459))
* Allow `debugger` statements in development JavaScript ([#1487](https://github.com/roots/sage/issues/1487))
### 8.2.1: May 7th, 2015 ### 8.2.1: May 7th, 2015
* Update BrowserSync ([#1457](https://github.com/roots/sage/issues/1457)) * Update BrowserSync ([#1457](https://github.com/roots/sage/issues/1457))

View File

@@ -57,7 +57,11 @@ var enabled = {
// Disable source maps when `--production` // Disable source maps when `--production`
maps: !argv.production, maps: !argv.production,
// Fail styles task on error when `--production` // Fail styles task on error when `--production`
failStyleTask: argv.production failStyleTask: argv.production,
// Fail due to JSHint warnings only when `--production`
failJSHint: argv.production,
// Strip debug statments from javascript when `--production`
stripJSDebug: argv.production
}; };
// Path to the compiled assets manifest in the dist directory // Path to the compiled assets manifest in the dist directory
@@ -128,7 +132,11 @@ var jsTasks = function(filename) {
return gulpif(enabled.maps, sourcemaps.init()); return gulpif(enabled.maps, sourcemaps.init());
}) })
.pipe(concat, filename) .pipe(concat, filename)
.pipe(uglify) .pipe(uglify, {
compress: {
'drop_debugger': enabled.stripJSDebug
}
})
.pipe(function() { .pipe(function() {
return gulpif(enabled.rev, rev()); return gulpif(enabled.rev, rev());
}) })
@@ -221,7 +229,7 @@ gulp.task('jshint', function() {
].concat(project.js)) ].concat(project.js))
.pipe(jshint()) .pipe(jshint())
.pipe(jshint.reporter('jshint-stylish')) .pipe(jshint.reporter('jshint-stylish'))
.pipe(jshint.reporter('fail')); .pipe(gulpif(enabled.failJSHint, jshint.reporter('fail')));
}); });
// ### Clean // ### Clean