diff --git a/CHANGELOG.md b/CHANGELOG.md index 1326ebd..39f1ae2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ### HEAD * Use `entry-summary` class for excerpts per Readability's Article Publishing Guidelines +* Cleanup/refactor `lib/activation.php` * Remove `lib/post-types.php` and `lib/metaboxes.php` * Make sure Primary Navigation menu always gets created and has the location set upon activation, update activation permalink method * Update to Bootstrap 2.2.1 diff --git a/lib/activation.php b/lib/activation.php index 867045e..d2c3a2c 100644 --- a/lib/activation.php +++ b/lib/activation.php @@ -75,7 +75,7 @@ function roots_theme_activation_options_render_page() { ?> $roots_default_activation_options = roots_get_default_theme_activation_options(); ?> - + @@ -83,8 +83,8 @@ function roots_theme_activation_options_render_page() { ?>

@@ -96,8 +96,8 @@ function roots_theme_activation_options_render_page() { ?>

@@ -109,8 +109,8 @@ function roots_theme_activation_options_render_page() { ?>

@@ -122,8 +122,8 @@ function roots_theme_activation_options_render_page() { ?>

@@ -135,8 +135,8 @@ function roots_theme_activation_options_render_page() { ?>

@@ -155,61 +155,20 @@ function roots_theme_activation_options_render_page() { ?> function roots_theme_activation_options_validate($input) { $output = $defaults = roots_get_default_theme_activation_options(); - if (isset($input['first_run'])) { - if ($input['first_run'] === '1') { - $input['first_run'] = true; - } - $output['first_run'] = $input['first_run']; - } + $options = array( + 'first_run', + 'create_front_page', + 'change_permalink_structure', + 'change_uploads_folder', + 'create_navigation_menus', + 'add_pages_to_primary_navigation' + ); - if (isset($input['create_front_page'])) { - if ($input['create_front_page'] === 'yes') { - $input['create_front_page'] = true; + foreach($options as $option_name) { + if (isset($input[$option_name])) { + $input[$option_name] = ($input[$option_name] === 'true') ? true : false; + $output[$option_name] = $input[$option_name]; } - if ($input['create_front_page'] === 'no') { - $input['create_front_page'] = false; - } - $output['create_front_page'] = $input['create_front_page']; - } - - if (isset($input['change_permalink_structure'])) { - if ($input['change_permalink_structure'] === 'yes') { - $input['change_permalink_structure'] = true; - } - if ($input['change_permalink_structure'] === 'no') { - $input['change_permalink_structure'] = false; - } - $output['change_permalink_structure'] = $input['change_permalink_structure']; - } - - if (isset($input['change_uploads_folder'])) { - if ($input['change_uploads_folder'] === 'yes') { - $input['change_uploads_folder'] = true; - } - if ($input['change_uploads_folder'] === 'no') { - $input['change_uploads_folder'] = false; - } - $output['change_uploads_folder'] = $input['change_uploads_folder']; - } - - if (isset($input['create_navigation_menus'])) { - if ($input['create_navigation_menus'] === 'yes') { - $input['create_navigation_menus'] = true; - } - if ($input['create_navigation_menus'] === 'no') { - $input['create_navigation_menus'] = false; - } - $output['create_navigation_menus'] = $input['create_navigation_menus']; - } - - if (isset($input['add_pages_to_primary_navigation'])) { - if ($input['add_pages_to_primary_navigation'] === 'yes') { - $input['add_pages_to_primary_navigation'] = true; - } - if ($input['add_pages_to_primary_navigation'] === 'no') { - $input['add_pages_to_primary_navigation'] = false; - } - $output['add_pages_to_primary_navigation'] = $input['add_pages_to_primary_navigation']; } return apply_filters('roots_theme_activation_options_validate', $output, $input, $defaults);